Skip to content

test#915

Closed
kryanbeane wants to merge 1 commit into
project-codeflare:ray-jobs-featurefrom
kryanbeane:e2e-test
Closed

test#915
kryanbeane wants to merge 1 commit into
project-codeflare:ray-jobs-featurefrom
kryanbeane:e2e-test

Conversation

@kryanbeane

@kryanbeane kryanbeane commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

Issue link

What changes have been made

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci Bot requested review from chipspeak and dimakis October 1, 2025 06:50
@openshift-ci

openshift-ci Bot commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chipspeak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov

codecov Bot commented Oct 1, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.14%. Comparing base (538d345) to head (3990360).

Files with missing lines Patch % Lines
src/codeflare_sdk/ray/cluster/config.py 50.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@                 Coverage Diff                  @@
##           ray-jobs-feature     #915      +/-   ##
====================================================
- Coverage             94.19%   94.14%   -0.05%     
====================================================
  Files                    21       21              
  Lines                  1911     1913       +2     
====================================================
+ Hits                   1800     1801       +1     
- Misses                  111      112       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kryanbeane kryanbeane closed this Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chipspeak chipspeak Awaiting requested review from chipspeak

@dimakis dimakis Awaiting requested review from dimakis

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kryanbeane